Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer unsafe hacks for AppendVec #3801

Merged
merged 9 commits into from
Apr 16, 2019

Conversation

aeyakovenko
Copy link
Member

@aeyakovenko aeyakovenko commented Apr 16, 2019

Problem

Account structure contains an embedded Vec which makes it hard to store in memory.

Summary of Changes

  • AppendVec stores the Account in several structures which are flat. In memory pointer fixups are no longer required.
  • Allow the compiler to track lifetimes.

Fixes #

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #3801 into master will increase coverage by <.1%.
The diff coverage is 95%.

@@           Coverage Diff            @@
##           master   #3801     +/-   ##
========================================
+ Coverage      79%     79%   +<.1%     
========================================
  Files         155     155             
  Lines       25269   25299     +30     
========================================
+ Hits        19982   20011     +29     
- Misses       5287    5288      +1

@aeyakovenko aeyakovenko merged commit 0ff2bfd into solana-labs:master Apr 16, 2019
danpaul000 pushed a commit to danpaul000/solana that referenced this pull request Apr 17, 2019
* storage account changes

* cleanup

* checks

* comments

* clippy

* tests

* woot!

* comments

* benches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants